Commit 70282930 authored by Greg Kurz's avatar Greg Kurz Committed by David Gibson
Browse files

spapr_pci: Improve error message 



Every PHB must have a unique index. This is checked at realize but when
a duplicate index is detected, an error message mentioning BUIDs is
printed. This doesn't help much, especially since BUID is an internal
concept that is no longer exposed to the user.

Fix the message to mention the index property instead of BUID. As a bonus
print a list of indexes already in use.

Signed-off-by: default avatarGreg Kurz <groug@kaod.org>
Message-Id: <155915010892.2061314.10485622810149098411.stgit@bahia.lan>
Signed-off-by: default avatarDavid Gibson <david@gibson.dropbear.id.au>
parent 219dca61

hw/ppc/spapr_pci.c

+8 −1
Original line number Diff line number Diff line
@@ -1677,7 +1677,14 @@ static void spapr_phb_realize(DeviceState *dev, Error **errp) 
    }



    if (spapr_pci_find_phb(spapr, sphb->buid)) {

        error_setg(errp, "PCI host bridges must have unique BUIDs");

        SpaprPhbState *s;



        error_setg(errp, "PCI host bridges must have unique indexes");

        error_append_hint(errp, "The following indexes are already in use:");

        QLIST_FOREACH(s, &spapr->phbs, list) {

            error_append_hint(errp, " %d", s->index);

        }

        error_append_hint(errp, "\nTry another value for the index property\n");

        return;

    }