Commit 6fa24902 authored by Dr. David Alan Gilbert's avatar Dr. David Alan Gilbert
Browse files

virtiofsd: fv_create_listen_socket error path socket leak 



If we fail when bringing up the socket we can leak the listen_fd;
in practice the daemon will exit so it's not really a problem.

Fixes: Coverity CID 1413121
Signed-off-by: default avatarDr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: default avatarPhilippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
parent 988717b4

tools/virtiofsd/fuse_virtio.c

+2 −0
Original line number Diff line number Diff line
@@ -916,6 +916,7 @@ static int fv_create_listen_socket(struct fuse_session *se) 
    old_umask = umask(0077);

    if (bind(listen_sock, (struct sockaddr *)&un, addr_len) == -1) {

        fuse_log(FUSE_LOG_ERR, "vhost socket bind: %m\n");

        close(listen_sock);

        umask(old_umask);

        return -1;

    }
@@ -923,6 +924,7 @@ static int fv_create_listen_socket(struct fuse_session *se) 


    if (listen(listen_sock, 1) == -1) {

        fuse_log(FUSE_LOG_ERR, "vhost socket listen: %m\n");

        close(listen_sock);

        return -1;

    }