Commit 6f16f7c5 authored by Kevin Wolf's avatar Kevin Wolf
Browse files

vhdx: Check for 4 GB maximum log size on creation 



It's unclear what the real maximum is, but we use an uint32_t to store
the log size in vhdx_co_create(), so we should check that the given
value fits in 32 bits.

Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
Reviewed-by: default avatarEric Blake <eblake@redhat.com>
Reviewed-by: default avatarJeff Cody <jcody@redhat.com>
parent 0fcc38e7

block/vhdx.c

+4 −0
Original line number Diff line number Diff line
@@ -1829,6 +1829,10 @@ static int coroutine_fn vhdx_co_create(BlockdevCreateOptions *opts, 
    if (!vhdx_opts->has_log_size) {

        log_size = DEFAULT_LOG_SIZE;

    } else {

        if (vhdx_opts->log_size > UINT32_MAX) {

            error_setg(errp, "Log size must be smaller than 4 GB");

            return -EINVAL;

        }

        log_size = vhdx_opts->log_size;

    }

    if (log_size < MiB || (log_size % MiB) != 0) {