Commit 6ef8cd7a authored by Daniel P. Berrangé's avatar Daniel P. Berrangé
Browse files

crypto: fix mistaken setting of Error in success code path 



The qcrypto_tls_session_check_certificate() method was setting
an Error even when the ACL check suceeded. This didn't affect
the callers detection of errors because they relied on the
function return status, but this did cause a memory leak since
the caller would not free an Error they did not expect to be
set.

Signed-off-by: default avatarDaniel P. Berrange <berrange@redhat.com>
parent 61b9251a

crypto/tlssession.c

+2 −2
Original line number Diff line number Diff line
@@ -304,9 +304,9 @@ qcrypto_tls_session_check_certificate(QCryptoTLSSession *session, 


                allow = qemu_acl_party_is_allowed(acl, session->peername);



                error_setg(errp, "TLS x509 ACL check for %s is %s",

                           session->peername, allow ? "allowed" : "denied");

                if (!allow) {

                    error_setg(errp, "TLS x509 ACL check for %s is denied",

                               session->peername);

                    goto error;

                }

            }