Commit 6e82e4bc authored by Fam Zheng's avatar Fam Zheng Committed by Stefan Hajnoczi
Browse files

block: Remove bdrv_reset_dirty 



Using this function would always be wrong because a dirty bitmap must
have a specific owner that consumes the dirty bits and calls
bdrv_reset_dirty_bitmap().

Remove the unused function to avoid future misuse.

Reviewed-by: default avatarEric Blake <eblake@redhat.com>
Signed-off-by: default avatarFam Zheng <famz@redhat.com>
Reviewed-by: default avatarJohn Snow <jsnow@redhat.com>
Signed-off-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
parent 50824995

block.c

+0 −12
Original line number Diff line number Diff line
@@ -3528,18 +3528,6 @@ void bdrv_set_dirty(BlockDriverState *bs, int64_t cur_sector, 
    }

}



void bdrv_reset_dirty(BlockDriverState *bs, int64_t cur_sector,

                      int nr_sectors)

{

    BdrvDirtyBitmap *bitmap;

    QLIST_FOREACH(bitmap, &bs->dirty_bitmaps, list) {

        if (!bdrv_dirty_bitmap_enabled(bitmap)) {

            continue;

        }

        hbitmap_reset(bitmap->bitmap, cur_sector, nr_sectors);

    }

}



/**

 * Advance an HBitmapIter to an arbitrary offset.

 */

include/block/block_int.h

+0 −2
Original line number Diff line number Diff line
@@ -662,7 +662,5 @@ bool blk_dev_is_medium_locked(BlockBackend *blk); 
void blk_dev_resize_cb(BlockBackend *blk);



void bdrv_set_dirty(BlockDriverState *bs, int64_t cur_sector, int nr_sectors);

void bdrv_reset_dirty(BlockDriverState *bs, int64_t cur_sector,

                      int nr_sectors);



#endif /* BLOCK_INT_H */