Commit 6ca62eb5 authored by David Hildenbrand's avatar David Hildenbrand Committed by Cornelia Huck
Browse files

s390x/tcg: tolerate wrong wakeups due to floating interrupts 



This is a preparation for floating interrupt support and only applies to
MTTCG, single threaded TCG works just fine. If a floating interrupt wakes
up a VCPU and the CPU thinks it can run (clearing cs->halted), at
the point where the interrupt would be delivered, already another VCPU
might have picked up the interrupt, resulting in a wakeup without an
interrupt (executing wrong code).

It is wrong to let the VCPU continue to execute (the WAIT PSW). Instead,
we have to put the VCPU back to sleep.

Signed-off-by: default avatarDavid Hildenbrand <david@redhat.com>
Message-Id: <20180129125623.21729-8-david@redhat.com>
Signed-off-by: default avatarCornelia Huck <cohuck@redhat.com>
parent d8d7942d

target/s390x/excp_helper.c

+5 −0
Original line number Diff line number Diff line
@@ -503,6 +503,11 @@ bool s390_cpu_exec_interrupt(CPUState *cs, int interrupt_request) 
            s390_cpu_do_interrupt(cs);

            return true;

        }

        if (env->psw.mask & PSW_MASK_WAIT) {

            /* Woken up because of a floating interrupt but it has already

             * been delivered. Go back to sleep. */

            cpu_interrupt(CPU(cpu), CPU_INTERRUPT_HALT);

        }

    }

    return false;

}