Commit 6c870535 authored by Kevin Wolf's avatar Kevin Wolf
Browse files

iotests: Attach new devices to node in non-default iothread 



This tests that devices refuse to be attached to a node that has already
been moved to a different iothread if they can't be or aren't configured
to work in the same iothread.

Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
parent edbe36ad

tests/qemu-iotests/051

+24 −0
Original line number Diff line number Diff line
@@ -191,6 +191,30 @@ case "$QEMU_DEFAULT_MACHINE" in 
        ;;

esac



echo

echo === Attach to node in non-default iothread ===

echo



case "$QEMU_DEFAULT_MACHINE" in

    pc)

        iothread="-drive file=$TEST_IMG,if=none,node-name=disk -object iothread,id=thread0 -device virtio-scsi,iothread=thread0,id=virtio-scsi0 -device scsi-hd,bus=virtio-scsi0.0,drive=disk,share-rw=on"



        # Can't add a device in the main thread while virtio-scsi0 uses the node

        run_qemu $iothread -device ide-hd,drive=disk,share-rw=on

        run_qemu $iothread -device virtio-blk-pci,drive=disk,share-rw=on

        run_qemu $iothread -device lsi53c895a,id=lsi0 -device scsi-hd,bus=lsi0.0,drive=disk,share-rw=on

        run_qemu $iothread -device virtio-scsi,id=virtio-scsi1 -device scsi-hd,bus=virtio-scsi1.0,drive=disk,share-rw=on



        # virtio-blk enables the iothread only when the driver initialises the

        # device, so a second virtio-blk device can't be added even with the

        # same iothread. virtio-scsi allows this.

        run_qemu $iothread -device virtio-blk-pci,drive=disk,iohtread=iothread0,share-rw=on

        run_qemu $iothread -device virtio-scsi,id=virtio-scsi1,iothread=thread0 -device scsi-hd,bus=virtio-scsi1.0,drive=disk,share-rw=on

        ;;

     *)

        ;;

esac



echo

echo === Read-only ===

echo

tests/qemu-iotests/051.out

+3 −0
Original line number Diff line number Diff line
@@ -137,6 +137,9 @@ QEMU X.Y.Z monitor - type 'help' for more information 
(qemu) QEMU_PROG: -drive if=virtio: Device needs media, but drive is empty





=== Attach to node in non-default iothread ===





=== Read-only ===



Testing: -drive file=TEST_DIR/t.qcow2,if=virtio,readonly=on

tests/qemu-iotests/051.pc.out

+27 −0
Original line number Diff line number Diff line
@@ -173,6 +173,33 @@ QEMU X.Y.Z monitor - type 'help' for more information 
(qemu) QEMU_PROG: -device scsi-hd,drive=disk: Device needs media, but drive is empty





=== Attach to node in non-default iothread ===



Testing: -drive file=TEST_DIR/t.qcow2,if=none,node-name=disk -object iothread,id=thread0 -device virtio-scsi,iothread=thread0,id=virtio-scsi0 -device scsi-hd,bus=virtio-scsi0.0,drive=disk,share-rw=on -device ide-hd,drive=disk,share-rw=on

QEMU X.Y.Z monitor - type 'help' for more information

(qemu) QEMU_PROG: -device ide-hd,drive=disk,share-rw=on: Cannot change iothread of active block backend



Testing: -drive file=TEST_DIR/t.qcow2,if=none,node-name=disk -object iothread,id=thread0 -device virtio-scsi,iothread=thread0,id=virtio-scsi0 -device scsi-hd,bus=virtio-scsi0.0,drive=disk,share-rw=on -device virtio-blk-pci,drive=disk,share-rw=on

QEMU X.Y.Z monitor - type 'help' for more information

(qemu) QEMU_PROG: -device virtio-blk-pci,drive=disk,share-rw=on: Cannot change iothread of active block backend



Testing: -drive file=TEST_DIR/t.qcow2,if=none,node-name=disk -object iothread,id=thread0 -device virtio-scsi,iothread=thread0,id=virtio-scsi0 -device scsi-hd,bus=virtio-scsi0.0,drive=disk,share-rw=on -device lsi53c895a,id=lsi0 -device scsi-hd,bus=lsi0.0,drive=disk,share-rw=on

QEMU X.Y.Z monitor - type 'help' for more information

(qemu) QEMU_PROG: -device scsi-hd,bus=lsi0.0,drive=disk,share-rw=on: HBA does not support iothreads



Testing: -drive file=TEST_DIR/t.qcow2,if=none,node-name=disk -object iothread,id=thread0 -device virtio-scsi,iothread=thread0,id=virtio-scsi0 -device scsi-hd,bus=virtio-scsi0.0,drive=disk,share-rw=on -device virtio-scsi,id=virtio-scsi1 -device scsi-hd,bus=virtio-scsi1.0,drive=disk,share-rw=on

QEMU X.Y.Z monitor - type 'help' for more information

(qemu) QEMU_PROG: -device scsi-hd,bus=virtio-scsi1.0,drive=disk,share-rw=on: Cannot change iothread of active block backend



Testing: -drive file=TEST_DIR/t.qcow2,if=none,node-name=disk -object iothread,id=thread0 -device virtio-scsi,iothread=thread0,id=virtio-scsi0 -device scsi-hd,bus=virtio-scsi0.0,drive=disk,share-rw=on -device virtio-blk-pci,drive=disk,iohtread=iothread0,share-rw=on

QEMU X.Y.Z monitor - type 'help' for more information

(qemu) QEMU_PROG: -device virtio-blk-pci,drive=disk,iohtread=iothread0,share-rw=on: Cannot change iothread of active block backend



Testing: -drive file=TEST_DIR/t.qcow2,if=none,node-name=disk -object iothread,id=thread0 -device virtio-scsi,iothread=thread0,id=virtio-scsi0 -device scsi-hd,bus=virtio-scsi0.0,drive=disk,share-rw=on -device virtio-scsi,id=virtio-scsi1,iothread=thread0 -device scsi-hd,bus=virtio-scsi1.0,drive=disk,share-rw=on

QEMU X.Y.Z monitor - type 'help' for more information

(qemu) quit





=== Read-only ===



Testing: -drive file=TEST_DIR/t.qcow2,if=floppy,readonly=on