Commit 6c77aa90 authored by Igor Mammedov's avatar Igor Mammedov Committed by Michael S. Tsirkin
Browse files

tests: acpi: always retain dumped ACPI tables in case of error 



If IASL wasn't able to parse expected file, test will just
print warning
  "Warning! iasl couldn't parse the expected aml\n"
and remove temporary table dumped from guest.

Typically expected tables are always valid, with an exception
when patchset introduces new tables.
Make sure dumped tables are retained even if expected files
are not valid, so one could have a chance to manualy check new
tables.

Signed-off-by: default avatarIgor Mammedov <imammedo@redhat.com>
Message-Id: <1574240560-12538-1-git-send-email-imammedo@redhat.com>
Reviewed-by: default avatarMichael S. Tsirkin <mst@redhat.com>
Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
parent ec244b17

tests/bios-tables-test.c

+1 −1
Original line number Diff line number Diff line
@@ -437,11 +437,11 @@ static void test_acpi_asl(test_data *data) 
        g_assert(!err || exp_err);



        if (g_strcmp0(asl->str, exp_asl->str)) {

            sdt->tmp_files_retain = true;

            if (exp_err) {

                fprintf(stderr,

                        "Warning! iasl couldn't parse the expected aml\n");

            } else {

                sdt->tmp_files_retain = true;

                exp_sdt->tmp_files_retain = true;

                fprintf(stderr,

                        "acpi-test: Warning! %.4s mismatch. "