Commit 6c1b663c authored by ChenLiang's avatar ChenLiang Committed by Amit Shah
Browse files

migration: static variables will not be reset at second migration 



The static variables in migration_bitmap_sync will not be reset in
the case of a second attempted migration.

Signed-off-by: default avatarChenLiang <chenliang88@huawei.com>
Signed-off-by: default avatarGonglei <arei.gonglei@huawei.com>
Reviewed-by: default avatarDr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: default avatarAmit Shah <amit.shah@redhat.com>
parent af3ff19b

arch_init.c

+12 −3
Original line number Diff line number Diff line
@@ -486,15 +486,23 @@ static void migration_bitmap_sync_range(ram_addr_t start, ram_addr_t length) 




/* Needs iothread lock! */

/* Fix me: there are too many global variables used in migration process. */

static int64_t start_time;

static int64_t bytes_xfer_prev;

static int64_t num_dirty_pages_period;



static void migration_bitmap_sync_init(void)

{

    start_time = 0;

    bytes_xfer_prev = 0;

    num_dirty_pages_period = 0;

}



static void migration_bitmap_sync(void)

{

    RAMBlock *block;

    uint64_t num_dirty_pages_init = migration_dirty_pages;

    MigrationState *s = migrate_get_current();

    static int64_t start_time;

    static int64_t bytes_xfer_prev;

    static int64_t num_dirty_pages_period;

    int64_t end_time;

    int64_t bytes_xfer_now;

    static uint64_t xbzrle_cache_miss_prev;
@@ -774,6 +782,7 @@ static int ram_save_setup(QEMUFile *f, void *opaque) 
    mig_throttle_on = false;

    dirty_rate_high_cnt = 0;

    bitmap_sync_count = 0;

    migration_bitmap_sync_init();



    if (migrate_use_xbzrle()) {

        XBZRLE_cache_lock();