Commit 6bf1faa8 authored by Denis V. Lunev's avatar Denis V. Lunev Committed by Stefan Hajnoczi
Browse files

monitor: add missed aio_context_acquire into vm_completion call 



Signed-off-by: default avatarDenis V. Lunev <den@openvz.org>
CC: Stefan Hajnoczi <stefanha@redhat.com>
CC: Kevin Wolf <kwolf@redhat.com>
CC: Luiz Capitulino <lcapitulino@redhat.com>
CC: Markus Armbruster <armbru@redhat.com>
Signed-off-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
parent fbe3fc5c

monitor.c

+8 −3
Original line number Diff line number Diff line
@@ -3408,13 +3408,18 @@ static void vm_completion(ReadLineState *rs, const char *str) 
    readline_set_completion_index(rs, len);

    while ((bs = bdrv_next(bs))) {

        SnapshotInfoList *snapshots, *snapshot;

        AioContext *ctx = bdrv_get_aio_context(bs);

        bool ok = false;



        if (!bdrv_can_snapshot(bs)) {

            continue;

        aio_context_acquire(ctx);

        if (bdrv_can_snapshot(bs)) {

            ok = bdrv_query_snapshot_info_list(bs, &snapshots, NULL) == 0;

        }

        if (bdrv_query_snapshot_info_list(bs, &snapshots, NULL)) {

        aio_context_release(ctx);

        if (!ok) {

            continue;

        }



        snapshot = snapshots;

        while (snapshot) {

            char *completion = snapshot->value->name;