Commit 6b9d62c2 authored by Markus Armbruster's avatar Markus Armbruster Committed by Kevin Wolf
Browse files

pr-manager: Fix invalid g_free() crash bug 



pr_manager_worker() passes its @opaque argument to g_free().  Wrong;
it points to pr_manager_worker()'s automatic @data.  Broken when
commit 2f3a7ab3 converted @data from heap- to stack-allocated.  Fix
by deleting the g_free().

Fixes: 2f3a7ab3
Cc: qemu-stable@nongnu.org
Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
Reviewed-by: default avatarPhilippe Mathieu-Daudé <philmd@redhat.com>
Acked-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
parent ae6ef019

scsi/pr-manager.c

+0 −1
Original line number Diff line number Diff line
@@ -39,7 +39,6 @@ static int pr_manager_worker(void *opaque) 
    int fd = data->fd;

    int r;



    g_free(data);

    trace_pr_manager_run(fd, hdr->cmdp[0], hdr->cmdp[1]);



    /* The reference was taken in pr_manager_execute.  */