Commit 6a7b2b21 authored by Marc-André Lureau's avatar Marc-André Lureau Committed by Paolo Bonzini
Browse files

char: update read handler in all cases 



In commit ac1b84dd (rhbz#1027181), a check was added to only update the
"read handler" when the front-end is opened, because the read callbacks
were not restored when a device is plugged. However, this seems not
correct, the handler is correctly set back on hotplug (in
virtconsole_realize) and the bug can no longer be reproduced.

Calling chr_update_read_handler() allows to fix the mux driver to stop
calling the child handlers (which may be going to be destroyed).

Signed-off-by: default avatarMarc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20161003094704.18087-2-marcandre.lureau@redhat.com>
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
parent 949055a2

qemu-char.c

+1 −1
Original line number Diff line number Diff line
@@ -469,7 +469,7 @@ void qemu_chr_add_handlers_full(CharDriverState *s, 
    s->chr_read = fd_read;

    s->chr_event = fd_event;

    s->handler_opaque = opaque;

    if (fe_open && s->chr_update_read_handler) {

    if (s->chr_update_read_handler) {

        s->chr_update_read_handler(s, context);

    }