Commit 6998b6c7 authored by Vijay Kumar B's avatar Vijay Kumar B Committed by Gerd Hoffmann
Browse files

usb: Fix incorrect default DMA offset. 



The default DMA offset is set to 3. When the property is not set by
the consumer, the default causes DMA access to be shifted by 3
bytes. In PXA, this results in incorrect DMA access, leading to error
notification in the USB controller driver. A better default would be
0, so that there is no offset, when the consumer does not specify one.

Signed-off-by: default avatarVijay Kumar B. <vijaykumar@zilogic.com>
Reviewed-by: default avatarDeepak S. <deepak@zilogic.com>
Message-id: 1475060958-7760-1-git-send-email-vijaykumar@zilogic.com
Signed-off-by: default avatarGerd Hoffmann <kraxel@redhat.com>
parent 0136464d

hw/usb/hcd-ohci.c

+1 −1
Original line number Diff line number Diff line
@@ -2139,7 +2139,7 @@ static const TypeInfo ohci_pci_info = { 


static Property ohci_sysbus_properties[] = {

    DEFINE_PROP_UINT32("num-ports", OHCISysBusState, num_ports, 3),

    DEFINE_PROP_DMAADDR("dma-offset", OHCISysBusState, dma_offset, 3),

    DEFINE_PROP_DMAADDR("dma-offset", OHCISysBusState, dma_offset, 0),

    DEFINE_PROP_END_OF_LIST(),

};