Commit 689ed13e authored by Daniel P. Berrangé's avatar Daniel P. Berrangé
Browse files

io: fix check for handshake completion in TLS test 



The TLS I/O channel test had mistakenly used && instead
of || when checking for handshake completion. As a
result it could terminate the handshake process before
it had actually completed. This was harmless before but
changes in GNUTLS 3.6.0 exposed this bug and caused the
test suite to fail.

Reviewed-by: default avatarEric Blake <eblake@redhat.com>
Signed-off-by: default avatarDaniel P. Berrange <berrange@redhat.com>
parent d4622e55

tests/test-io-channel-tls.c

+1 −1
Original line number Diff line number Diff line
@@ -218,7 +218,7 @@ static void test_io_channel_tls(const void *opaque) 
    mainloop = g_main_context_default();

    do {

        g_main_context_iteration(mainloop, TRUE);

    } while (!clientHandshake.finished &&

    } while (!clientHandshake.finished ||

             !serverHandshake.finished);



    g_assert(clientHandshake.failed == data->expectClientFail);