Commit 67b792f5 authored by Vladimir Sementsov-Ogievskiy's avatar Vladimir Sementsov-Ogievskiy Committed by Max Reitz
Browse files

block: add bdrv_can_store_new_dirty_bitmap 



This will be needed to check some restrictions before making bitmap
persistent in qmp-block-dirty-bitmap-add (this functionality will be
added by future patch)

Signed-off-by: default avatarVladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: default avatarMax Reitz <mreitz@redhat.com>
Reviewed-by: default avatarJohn Snow <jsnow@redhat.com>
Message-id: 20170628120530.31251-22-vsementsov@virtuozzo.com
Signed-off-by: default avatarMax Reitz <mreitz@redhat.com>
parent 169b8793

block.c

+22 −0
Original line number Diff line number Diff line
@@ -4880,3 +4880,25 @@ void bdrv_del_child(BlockDriverState *parent_bs, BdrvChild *child, Error **errp) 


    parent_bs->drv->bdrv_del_child(parent_bs, child, errp);

}



bool bdrv_can_store_new_dirty_bitmap(BlockDriverState *bs, const char *name,

                                     uint32_t granularity, Error **errp)

{

    BlockDriver *drv = bs->drv;



    if (!drv) {

        error_setg_errno(errp, ENOMEDIUM,

                         "Can't store persistent bitmaps to %s",

                         bdrv_get_device_or_node_name(bs));

        return false;

    }



    if (!drv->bdrv_can_store_new_dirty_bitmap) {

        error_setg_errno(errp, ENOTSUP,

                         "Can't store persistent bitmaps to %s",

                         bdrv_get_device_or_node_name(bs));

        return false;

    }



    return drv->bdrv_can_store_new_dirty_bitmap(bs, name, granularity, errp);

}

include/block/block.h

+3 −0
Original line number Diff line number Diff line
@@ -617,4 +617,7 @@ void bdrv_add_child(BlockDriverState *parent, BlockDriverState *child, 
                    Error **errp);

void bdrv_del_child(BlockDriverState *parent, BdrvChild *child, Error **errp);



bool bdrv_can_store_new_dirty_bitmap(BlockDriverState *bs, const char *name,

                                     uint32_t granularity, Error **errp);



#endif

include/block/block_int.h

+4 −0
Original line number Diff line number Diff line
@@ -387,6 +387,10 @@ struct BlockDriver { 
     * field of BlockDirtyBitmap's in case of success.

     */

    int (*bdrv_reopen_bitmaps_rw)(BlockDriverState *bs, Error **errp);

    bool (*bdrv_can_store_new_dirty_bitmap)(BlockDriverState *bs,

                                            const char *name,

                                            uint32_t granularity,

                                            Error **errp);



    QLIST_ENTRY(BlockDriver) list;

};