Commit 675a7756 authored by Paolo Bonzini's avatar Paolo Bonzini Committed by Jeff Cody
Browse files

curl: strengthen assertion in curl_clean_state 



curl_clean_state should only be called after all AIOCBs have been
completed.  This is not so obvious for the call from curl_detach_aio_context,
so assert that.

Cc: qemu-stable@nongnu.org
Reviewed-by: default avatarJeff Cody <jcody@redhat.com>
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
Reviewed-by: default avatarMax Reitz <mreitz@redhat.com>
Message-id: 20170515100059.15795-2-pbonzini@redhat.com
Signed-off-by: default avatarJeff Cody <jcody@redhat.com>
parent 327c8ebd

block/curl.c

+5 −0
Original line number Diff line number Diff line
@@ -533,6 +533,11 @@ static CURLState *curl_init_state(BlockDriverState *bs, BDRVCURLState *s) 


static void curl_clean_state(CURLState *s)

{

    int j;

    for (j = 0; j < CURL_NUM_ACB; j++) {

        assert(!s->acb[j]);

    }



    if (s->s->multi)

        curl_multi_remove_handle(s->s->multi, s->curl);