Commit 673b0add authored by Kashyap Chamarthy's avatar Kashyap Chamarthy Committed by Paolo Bonzini
Browse files

target/i386: Add the 'model-id' for Skylake -v3 CPU models 



This fixes a confusion in the help output.  (Although, if you squint
long enough at the '-cpu help' output, you _do_ notice that
"Skylake-Client-noTSX-IBRS" is an alias of "Skylake-Client-v3";
similarly for Skylake-Server-v3.)

Without this patch:

    $ qemu-system-x86 -cpu help
    ...
    x86 Skylake-Client-v1     Intel Core Processor (Skylake)
    x86 Skylake-Client-v2     Intel Core Processor (Skylake, IBRS)
    x86 Skylake-Client-v3     Intel Core Processor (Skylake, IBRS)
    ...
    x86 Skylake-Server-v1     Intel Xeon Processor (Skylake)
    x86 Skylake-Server-v2     Intel Xeon Processor (Skylake, IBRS)
    x86 Skylake-Server-v3     Intel Xeon Processor (Skylake, IBRS)
    ...

With this patch:

    $ ./qemu-system-x86 -cpu help
    ...
    x86 Skylake-Client-v1     Intel Core Processor (Skylake)
    x86 Skylake-Client-v2     Intel Core Processor (Skylake, IBRS)
    x86 Skylake-Client-v3     Intel Core Processor (Skylake, IBRS, no TSX)
    ...
    x86 Skylake-Server-v1     Intel Xeon Processor (Skylake)
    x86 Skylake-Server-v2     Intel Xeon Processor (Skylake, IBRS)
    x86 Skylake-Server-v3     Intel Xeon Processor (Skylake, IBRS, no TSX)
    ...

Signed-off-by: default avatarKashyap Chamarthy <kchamart@redhat.com>
Message-Id: <20200123090116.14409-1-kchamart@redhat.com>
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
parent e1043d67

target/i386/cpu.c

+4 −0
Original line number Diff line number Diff line
@@ -2905,6 +2905,8 @@ static X86CPUDefinition builtin_x86_defs[] = { 
                .props = (PropValue[]) {

                    { "hle", "off" },

                    { "rtm", "off" },

                    { "model-id",

                      "Intel Core Processor (Skylake, IBRS, no TSX)" },

                    { /* end of list */ }

                }

            },
@@ -3028,6 +3030,8 @@ static X86CPUDefinition builtin_x86_defs[] = { 
                .props = (PropValue[]) {

                    { "hle", "off" },

                    { "rtm", "off" },

                    { "model-id",

                      "Intel Xeon Processor (Skylake, IBRS, no TSX)" },

                    { /* end of list */ }

                }

            },