Commit 6653d131 authored by Andrey Shinkevich's avatar Andrey Shinkevich Committed by Max Reitz
Browse files

hw/block/fdc: floppy command FIFO memory initialization 



The uninitialized memory allocated for the command FIFO of the
floppy controller during the VM hardware initialization incurs
many unwanted reports by Valgrind when VM state is being saved.
That verbosity hardens a search for the real memory issues when
the iotests run. Particularly, the patch eliminates 20 unnecessary
reports of the Valgrind tool in the iotest #169.

Signed-off-by: default avatarAndrey Shinkevich <andrey.shinkevich@virtuozzo.com>
Message-id: 1559154027-282547-1-git-send-email-andrey.shinkevich@virtuozzo.com
Reviewed-by: default avatarJohn Snow <jsnow@redhat.com>
Signed-off-by: default avatarMax Reitz <mreitz@redhat.com>
parent d9efe938

hw/block/fdc.c

+1 −0
Original line number Diff line number Diff line
@@ -2648,6 +2648,7 @@ static void fdctrl_realize_common(DeviceState *dev, FDCtrl *fdctrl, 


    FLOPPY_DPRINTF("init controller\n");

    fdctrl->fifo = qemu_memalign(512, FD_SECTOR_LEN);

    memset(fdctrl->fifo, 0, FD_SECTOR_LEN);

    fdctrl->fifo_size = 512;

    fdctrl->result_timer = timer_new_ns(QEMU_CLOCK_VIRTUAL,

                                             fdctrl_result_timer, fdctrl);