Commit 657ada52 authored by Leonid Bloch's avatar Leonid Bloch Committed by Kevin Wolf
Browse files

qcow2: Avoid duplication in setting the refcount cache size 



The refcount cache size does not need to be set to its minimum value in
read_cache_sizes(), as it is set to at least its minimum value in
qcow2_update_options_prepare().

Signed-off-by: default avatarLeonid Bloch <lbloch@janustech.com>
Reviewed-by: default avatarAlberto Garcia <berto@igalia.com>
Reviewed-by: default avatarKevin Wolf <kwolf@redhat.com>
Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
parent b6a95c6d

block/qcow2.c

+2 −3
Original line number Diff line number Diff line
@@ -834,10 +834,9 @@ static void read_cache_sizes(BlockDriverState *bs, QemuOpts *opts, 
                                 (uint64_t)DEFAULT_L2_CACHE_CLUSTERS

                                 * s->cluster_size);

        }

        if (!refcount_cache_size_set) {

            *refcount_cache_size = min_refcount_cache;

        }

    }

    /* l2_cache_size and refcount_cache_size are ensured to have at least

     * their minimum values in qcow2_update_options_prepare() */



    if (*l2_cache_entry_size < (1 << MIN_CLUSTER_BITS) ||

        *l2_cache_entry_size > s->cluster_size ||