Commit 65018100 authored by Juan Quintela's avatar Juan Quintela Committed by Jason Wang
Browse files

virtio-net: fix removal of failover device 

If you have a networking device and its virtio failover device, and
you remove them in this order:
- virtio device
- the real device

You get qemu crash.
See bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1820120



Bug exist on qemu 4.2 and 5.0.
But in 5.0 don't shows because commit
77b06bba

somehow papers over it.

CC: Jason Wang <jasowang@redhat.com>
CC: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: default avatarMichael S. Tsirkin <mst@redhat.com>
Acked-by: default avatarLaurent Vivier <lvivier@redhat.com>
Signed-off-by: default avatarJuan Quintela <quintela@redhat.com>
Signed-off-by: default avatarJason Wang <jasowang@redhat.com>
parent 67320537

hw/net/virtio-net.c

+1 −0
Original line number Diff line number Diff line
@@ -3416,6 +3416,7 @@ static void virtio_net_device_unrealize(DeviceState *dev) 
    g_free(n->vlans);



    if (n->failover) {

        device_listener_unregister(&n->primary_listener);

        g_free(n->primary_device_id);

        g_free(n->standby_id);

        qobject_unref(n->primary_device_dict);