Commit 642e065a authored by Marc-André Lureau's avatar Marc-André Lureau Committed by Paolo Bonzini
Browse files

vhost-user-test: do not hang if chardev creation failed 



Before the chardev name fix, the following error may happen: "attempt
to add duplicate property 'chr-test' to object (type 'container')",
due to races.

Sadly, error_vprintf() uses g_test_message(), so you have to use
read the cryptic --debug-log to see it. Later, it would make sense to
use g_critical() instead, and catch errors with
g_test_expect_message() (in glib 2.34).

Signed-off-by: default avatarMarc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20180215212552.26997-5-marcandre.lureau@redhat.com>
Acked-by: default avatarMaxime Coquelin <maxime.coquelin@redhat.com>
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
parent 6ff8d9b0

tests/vhost-user-test.c

+1 −0
Original line number Diff line number Diff line
@@ -494,6 +494,7 @@ static void test_server_create_chr(TestServer *server, const gchar *opt) 
    chr = qemu_chr_new(server->chr_name, chr_path);

    g_free(chr_path);



    g_assert_nonnull(chr);

    qemu_chr_fe_init(&server->chr, chr, &error_abort);

    qemu_chr_fe_set_handlers(&server->chr, chr_can_read, chr_read,

                             chr_event, NULL, server, NULL, true);