Commit 626bba98 authored by Zhang Chen's avatar Zhang Chen Committed by Jason Wang
Browse files

net/colo-compare.c: Adjust net queue pop order for performance 



The packet_enqueue() use g_queue_push_tail() to
enqueue net packet, so it is more efficent way use
g_queue_pop_head() to get packet for compare.
That will improve the success rate of comparison.
In my test the performance of ftp put 1000M file
will increase 10%

Signed-off-by: default avatarZhang Chen <zhangchen.fnst@cn.fujitsu.com>
Signed-off-by: default avatarJason Wang <jasowang@redhat.com>
parent 6f5009c3

net/colo-compare.c

+2 −2
Original line number Diff line number Diff line
@@ -484,7 +484,7 @@ static void colo_compare_connection(void *opaque, void *user_data) 


    while (!g_queue_is_empty(&conn->primary_list) &&

           !g_queue_is_empty(&conn->secondary_list)) {

        pkt = g_queue_pop_tail(&conn->primary_list);

        pkt = g_queue_pop_head(&conn->primary_list);

        switch (conn->ip_proto) {

        case IPPROTO_TCP:

            result = g_queue_find_custom(&conn->secondary_list,
@@ -522,7 +522,7 @@ static void colo_compare_connection(void *opaque, void *user_data) 
             * until next comparison.

             */

            trace_colo_compare_main("packet different");

            g_queue_push_tail(&conn->primary_list, pkt);

            g_queue_push_head(&conn->primary_list, pkt);

            /* TODO: colo_notify_checkpoint();*/

            break;

        }