Commit 60798655 authored by Marc-André Lureau's avatar Marc-André Lureau Committed by Michael S. Tsirkin
Browse files

libvhost-user: exit by default on VHOST_USER_NONE 



Since commit 2566378d, libvhost-user
no longer panics on disconnect (rc == 0), and instead silently ignores
an invalid VHOST_USER_NONE message.

Without extra work from the API user, this will simply busy-loop on
HUP events. The obvious thing to do is to exit(0) instead, while
additional or different work can be done by overriding
iface->process_msg().

Signed-off-by: default avatarMarc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: default avatarJens Freimann <jfreimann@redhat.com>
Message-Id: <20190308140454.32437-5-marcandre.lureau@redhat.com>
Reviewed-by: default avatarMichael S. Tsirkin <mst@redhat.com>
Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
parent 0b99f224

contrib/libvhost-user/libvhost-user.c

+2 −1
Original line number Diff line number Diff line
@@ -1285,7 +1285,8 @@ vu_process_message(VuDev *dev, VhostUserMsg *vmsg) 
    case VHOST_USER_SET_CONFIG:

        return vu_set_config(dev, vmsg);

    case VHOST_USER_NONE:

        break;

        /* if you need processing before exit, override iface->process_msg */

        exit(0);

    case VHOST_USER_POSTCOPY_ADVISE:

        return vu_set_postcopy_advise(dev, vmsg);

    case VHOST_USER_POSTCOPY_LISTEN: