Commit 606fd0e2 authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Eduardo Habkost
Browse files

qdev: Constify value passed to qdev_prop_set_macaddr 



The 'value' argument is not modified so this can be made const for code
safeness.

Signed-off-by: default avatarKrzysztof Kozlowski <krzk@kernel.org>
Message-Id: <20170310200550.13313-2-krzk@kernel.org>
Signed-off-by: default avatarEduardo Habkost <ehabkost@redhat.com>
parent 6f4c60e4

hw/core/qdev-properties.c

+2 −1
Original line number Diff line number Diff line
@@ -1010,7 +1010,8 @@ void qdev_prop_set_string(DeviceState *dev, const char *name, const char *value) 
    object_property_set_str(OBJECT(dev), value, name, &error_abort);

}



void qdev_prop_set_macaddr(DeviceState *dev, const char *name, uint8_t *value)

void qdev_prop_set_macaddr(DeviceState *dev, const char *name,

                           const uint8_t *value)

{

    char str[2 * 6 + 5 + 1];

    snprintf(str, sizeof(str), "%02x:%02x:%02x:%02x:%02x:%02x",

include/hw/qdev-properties.h

+2 −1
Original line number Diff line number Diff line
@@ -188,7 +188,8 @@ void qdev_prop_set_chr(DeviceState *dev, const char *name, Chardev *value); 
void qdev_prop_set_netdev(DeviceState *dev, const char *name, NetClientState *value);

void qdev_prop_set_drive(DeviceState *dev, const char *name,

                         BlockBackend *value, Error **errp);

void qdev_prop_set_macaddr(DeviceState *dev, const char *name, uint8_t *value);

void qdev_prop_set_macaddr(DeviceState *dev, const char *name,

                           const uint8_t *value);

void qdev_prop_set_enum(DeviceState *dev, const char *name, int value);

/* FIXME: Remove opaque pointer properties.  */

void qdev_prop_set_ptr(DeviceState *dev, const char *name, void *value);