Commit 601b5575 authored by Alex Bennée's avatar Alex Bennée
Browse files

tests/migration-test: don't spam the logs when we fail 



Quite often the information about which test failed is hidden by the
wall of repeated failures for each page. Stop outputting the error
after 10 bad pages and just summarise the total damage at the end.

Signed-off-by: default avatarAlex Bennée <alex.bennee@linaro.org>
Reviewed-by: default avatarDr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: default avatarThomas Huth <thuth@redhat.com>
Reviewed-by: default avatarLaurent Vivier <lvivier@redhat.com>
parent 56e89a31

tests/migration-test.c

+12 −7
Original line number Diff line number Diff line
@@ -308,7 +308,7 @@ static void check_guests_ram(QTestState *who) 
    uint8_t first_byte;

    uint8_t last_byte;

    bool hit_edge = false;

    bool bad = false;

    int bad = 0;



    qtest_memread(who, start_address, &first_byte, 1);

    last_byte = first_byte;
@@ -327,15 +327,20 @@ static void check_guests_ram(QTestState *who) 
                hit_edge = true;

                last_byte = b;

            } else {

                bad++;

                if (bad <= 10) {

                    fprintf(stderr, "Memory content inconsistency at %x"

                            " first_byte = %x last_byte = %x current = %x"

                            " hit_edge = %x\n",

                            address, first_byte, last_byte, b, hit_edge);

                bad = true;

                }

            }

        }

    g_assert_false(bad);

    }

    if (bad >= 10) {

        fprintf(stderr, "and in another %d pages", bad - 10);

    }

    g_assert(bad == 0);

}



static void cleanup(const char *filename)