Commit 5e959d2e authored by Markus Armbruster's avatar Markus Armbruster
Browse files

s390x/cpumodel: Fix harmless misuse of visit_check_struct() 



Commit e47970f5 "s390x/cpumodel: Fix query-cpu-model-FOO error API
violations" neglected to change visit_check_struct()'s Error **
argument along with the others.  If visit_check_struct() failed, we'd
take the success path.  Fortunately, it can't fail here:
qobject_input_check_struct() checks we consumed the whole dictionary,
and to get here, we did.  Fix it anyway.

Cc: David Hildenbrand <david@redhat.com>
Cc: Cornelia Huck <cohuck@redhat.com>
Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
Reviewed-by: default avatarDavid Hildenbrand <david@redhat.com>
Reviewed-by: default avatarCornelia Huck <cohuck@redhat.com>
Message-Id: <20200505101908.6207-4-armbru@redhat.com>
parent 56f9dde4

target/s390x/cpu_models.c

+1 −1
Original line number Diff line number Diff line
@@ -524,7 +524,7 @@ static void cpu_model_from_info(S390CPUModel *model, const CpuModelInfo *info, 
            }

        }

        if (!err) {

            visit_check_struct(visitor, errp);

            visit_check_struct(visitor, &err);

        }

        visit_end_struct(visitor, NULL);

        visit_free(visitor);