Commit 5e3d741c authored by Marc-André Lureau's avatar Marc-André Lureau Committed by Gerd Hoffmann
Browse files

virtio-gpu: check max_outputs value 



The value must be less than VIRTIO_GPU_MAX_SCANOUT.

Signed-off-by: default avatarMarc-André Lureau <marcandre.lureau@redhat.com>
Message-id: 1463653560-26958-4-git-send-email-marcandre.lureau@redhat.com
Signed-off-by: default avatarGerd Hoffmann <kraxel@redhat.com>
parent d0f0c865

hw/display/virtio-gpu.c

+6 −0
Original line number Diff line number Diff line
@@ -20,6 +20,7 @@ 
#include "hw/virtio/virtio-gpu.h"

#include "hw/virtio/virtio-bus.h"

#include "qemu/log.h"

#include "qapi/error.h"



static struct virtio_gpu_simple_resource*

virtio_gpu_find_resource(VirtIOGPU *g, uint32_t resource_id);
@@ -929,6 +930,11 @@ static void virtio_gpu_device_realize(DeviceState *qdev, Error **errp) 
    bool have_virgl;

    int i;



    if (g->conf.max_outputs > VIRTIO_GPU_MAX_SCANOUT) {

        error_setg(errp, "invalid max_outputs > %d", VIRTIO_GPU_MAX_SCANOUT);

        return;

    }



    g->config_size = sizeof(struct virtio_gpu_config);

    g->virtio_config.num_scanouts = g->conf.max_outputs;

    virtio_init(VIRTIO_DEVICE(g), "virtio-gpu", VIRTIO_ID_GPU,