Commit 5e347892 authored by Peter Maydell's avatar Peter Maydell
Browse files

hw/timer/slavio_timer: Remove useless check for NULL t->timer 



In the slavio timer device, the ptimer TimerContext::timer is
always created by slavio_timer_init(), so there's no need to
check it for NULL; remove the single unneeded NULL check.

This will be useful to avoid compiler/Coverity errors when
a subsequent change adds a use of t->timer before the location
we currently do the NULL check.

Signed-off-by: default avatarPeter Maydell <peter.maydell@linaro.org>
Reviewed-by: default avatarPhilippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: default avatarRichard Henderson <richard.henderson@linaro.org>
Message-id: 20191021134357.14266-2-peter.maydell@linaro.org
Signed-off-by: default avatarPeter Maydell <peter.maydell@linaro.org>
parent e982ba05

hw/timer/slavio_timer.c

+5 −7
Original line number Diff line number Diff line
@@ -227,7 +227,6 @@ static void slavio_timer_mem_writel(void *opaque, hwaddr addr, 
            // set limit, reset counter

            qemu_irq_lower(t->irq);

            t->limit = val & TIMER_MAX_COUNT32;

            if (t->timer) {

            if (t->limit == 0) { /* free-run */

                ptimer_set_limit(t->timer,

                                 LIMIT_TO_PERIODS(TIMER_MAX_COUNT32), 1);
@@ -235,7 +234,6 @@ static void slavio_timer_mem_writel(void *opaque, hwaddr addr, 
                ptimer_set_limit(t->timer, LIMIT_TO_PERIODS(t->limit), 1);

            }

        }

        }

        break;

    case TIMER_COUNTER:

        if (slavio_timer_is_user(tc)) {