Commit 5e29521a authored by Philippe Mathieu-Daudé's avatar Philippe Mathieu-Daudé
Browse files

hw/avr/boot: Fix memory leak in avr_load_firmware() 



The value returned by qemu_find_file() must be freed.

This fixes Coverity issue CID 1430449, which points out
that the memory returned by qemu_find_file() is leaked.

Fixes: Coverity CID 1430449 (RESOURCE_LEAK)
Fixes: 7dd8f6fd ('hw/avr: Add support for loading ELF/raw binaries')
Signed-off-by: default avatarPhilippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: default avatarMichael Rolnik <mrolnik@gmail.com>
Tested-by: default avatarMichael Rolnik <mrolnik@gmail.com>
Reviewed-by: default avatarDaniel P. Berrangé <berrange@redhat.com>
Message-Id: <20200714164257.23330-5-f4bug@amsat.org>
parent b6c61f69

hw/avr/boot.c

+1 −1
Original line number Diff line number Diff line
@@ -60,7 +60,7 @@ static const char *avr_elf_e_flags_to_cpu_type(uint32_t flags) 
bool avr_load_firmware(AVRCPU *cpu, MachineState *ms,

                       MemoryRegion *program_mr, const char *firmware)

{

    const char *filename;

    g_autofree char *filename = NULL;

    int bytes_loaded;

    uint64_t entry;

    uint32_t e_flags;