Commit 5bee0f47 authored by Eric Blake's avatar Eric Blake Committed by Paolo Bonzini
Browse files

nbd: Fix bad flag detection on server 



Commit ab7c548e added a check for invalid flags, but used an
early return on error instead of properly going through the
cleanup label.

Signed-off-by: default avatarEric Blake <eblake@redhat.com>

Message-Id: <1469129688-22848-2-git-send-email-eblake@redhat.com>
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
parent 71ae65e5

nbd/server.c

+2 −1
Original line number Diff line number Diff line
@@ -1057,7 +1057,8 @@ static ssize_t nbd_co_receive_request(NBDRequest *req, 
    if (request->type & ~NBD_CMD_MASK_COMMAND & ~NBD_CMD_FLAG_FUA) {

        LOG("unsupported flags (got 0x%x)",

            request->type & ~NBD_CMD_MASK_COMMAND);

        return -EINVAL;

        rc = -EINVAL;

        goto out;

    }



    rc = 0;