Commit 5bd5c27c authored by Gerd Hoffmann's avatar Gerd Hoffmann
Browse files

qxl: fix local renderer crash 

Make sure we only ask the spice local renderer for display updates in
case we have a valid primary surface.  Without that spice is confused
and throws errors in case a display update request (triggered by
screendump for example) happens in parallel to a mode switch and hits
the race window where the old primary surface is gone and the new isn't
establisted yet.

Cc: qemu-stable@nongnu.org
Fixes: https://bugzilla.redhat.com//show_bug.cgi?id=1567733


Signed-off-by: default avatarGerd Hoffmann <kraxel@redhat.com>
Reviewed-by: default avatarMarc-André Lureau <marcandre.lureau@redhat.com>
Message-id: 20180427115528.345-1-kraxel@redhat.com
parent c8b7e627

hw/display/qxl-render.c

+2 −1
Original line number Diff line number Diff line
@@ -169,7 +169,8 @@ void qxl_render_update(PCIQXLDevice *qxl) 


    qemu_mutex_lock(&qxl->ssd.lock);



    if (!runstate_is_running() || !qxl->guest_primary.commands) {

    if (!runstate_is_running() || !qxl->guest_primary.commands ||

        qxl->mode == QXL_MODE_UNDEFINED) {

        qxl_render_update_area_unlocked(qxl);

        qemu_mutex_unlock(&qxl->ssd.lock);

        return;