Commit 5a693efd authored by Gonglei's avatar Gonglei Committed by Gerd Hoffmann
Browse files

vnc: fix incorrect checking condition when updating client 



vs->disconnecting is set to TRUE and vs->ioc is closed, but
vs->ioc isn't set to NULL, so that the vnc_disconnect_finish()
isn't invoked when you update client in vnc_update_client()
after vnc_disconnect_start invoked. Let's using change the checking
condition to avoid resource leak.

Signed-off-by: default avatarHaibin Wang <wanghaibin.wang@huawei.com>
Signed-off-by: default avatarGonglei <arei.gonglei@huawei.com>
Reviewed-by: default avatarDaniel P. Berrange <berrange@redhat.com>
Message-id: 1467949056-81208-1-git-send-email-arei.gonglei@huawei.com
Signed-off-by: default avatarGerd Hoffmann <kraxel@redhat.com>
parent f1ef5578

ui/vnc.c

+1 −1
Original line number Diff line number Diff line
@@ -1025,7 +1025,7 @@ static int find_and_clear_dirty_height(VncState *vs, 
static int vnc_update_client(VncState *vs, int has_dirty, bool sync)

{

    vs->has_dirty += has_dirty;

    if (vs->need_update && vs->ioc != NULL) {

    if (vs->need_update && !vs->disconnecting) {

        VncDisplay *vd = vs->vd;

        VncJob *job;

        int y;