Commit 58fa5494 authored by Marc-André Lureau's avatar Marc-André Lureau Committed by Paolo Bonzini
Browse files

char: remove unused qemu_chr_fe_event 

I introduced this function in d61b0c9a, but it isn't
used. Furthermore, it was incomplete, as it would need to translate QEMU
chr events to Spice port events.

(presumably it was used in the follow-up NBD-spice series that was not
completed: http://lists.gnu.org/archive/html/qemu-devel/2013-11/msg02024.html

)

Signed-off-by: default avatarMarc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20161022100951.19562-4-marcandre.lureau@redhat.com>
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
parent 8c260cb1

include/sysemu/char.h

+0 −11
Original line number Diff line number Diff line
@@ -103,7 +103,6 @@ struct CharDriverState { 
    void (*chr_accept_input)(struct CharDriverState *chr);

    void (*chr_set_echo)(struct CharDriverState *chr, bool echo);

    void (*chr_set_fe_open)(struct CharDriverState *chr, int fe_open);

    void (*chr_fe_event)(struct CharDriverState *chr, int event);

    CharBackend *be;

    void *opaque;

    char *label;
@@ -238,16 +237,6 @@ void qemu_chr_fe_set_echo(CharBackend *be, bool echo); 
 */

void qemu_chr_fe_set_open(CharBackend *be, int fe_open);



/**

 * @qemu_chr_fe_event:

 *

 * Send an event from the front end to the back end. It does nothing

 * without associated CharDriver.

 *

 * @event the event to send

 */

void qemu_chr_fe_event(CharBackend *be, int event);



/**

 * @qemu_chr_fe_printf:

 *

qemu-char.c

+0 −9
Original line number Diff line number Diff line
@@ -4226,15 +4226,6 @@ void qemu_chr_fe_set_open(CharBackend *be, int fe_open) 
    }

}



void qemu_chr_fe_event(CharBackend *be, int event)

{

    CharDriverState *chr = be->chr;



    if (chr && chr->chr_fe_event) {

        chr->chr_fe_event(chr, event);

    }

}



guint qemu_chr_fe_add_watch(CharBackend *be, GIOCondition cond,

                            GIOFunc func, void *user_data)

{

spice-qemu-char.c

+0 −10
Original line number Diff line number Diff line
@@ -236,15 +236,6 @@ static void spice_port_set_fe_open(struct CharDriverState *chr, int fe_open) 
#endif

}



static void spice_chr_fe_event(struct CharDriverState *chr, int event)

{

#if SPICE_SERVER_VERSION >= 0x000c02

    SpiceCharDriver *s = chr->opaque;



    spice_server_port_event(&s->sin, event);

#endif

}



static void print_allowed_subtypes(void)

{

    const char** psubtype;
@@ -292,7 +283,6 @@ static CharDriverState *chr_open(const char *subtype, 
    chr->chr_free = spice_chr_free;

    chr->chr_set_fe_open = set_fe_open;

    chr->explicit_be_open = true;

    chr->chr_fe_event = spice_chr_fe_event;

    chr->chr_accept_input = spice_chr_accept_input;



    QLIST_INSERT_HEAD(&spice_chars, s, next);