Commit 58eeb83c authored by Markus Armbruster's avatar Markus Armbruster Committed by Michael S. Tsirkin
Browse files

log: Permit -dfilter 0..0xffffffffffffffff 



Works fine since the previous commit fixed the underlying range data
type.  Of course it filters out nothing, but so does
0..1,2..0xffffffffffffffff, and we don't bother rejecting that either.

Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
Reviewed-by: default avatarEric Blake <eblake@redhat.com>
Reviewed-by: default avatarMichael S. Tsirkin <mst@redhat.com>
Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
parent 6dd726a2

tests/test-logging.c

+3 −2
Original line number Diff line number Diff line
@@ -73,7 +73,8 @@ static void test_parse_range(void) 
    g_assert_false(qemu_log_in_addr_range(UINT64_MAX - 1));



    qemu_set_dfilter_ranges("0..0xffffffffffffffff", &err);

    error_free_or_abort(&err);

    g_assert(qemu_log_in_addr_range(0));

    g_assert(qemu_log_in_addr_range(UINT64_MAX));

 

    qemu_set_dfilter_ranges("2..1", &err);

    error_free_or_abort(&err);

util/log.c

+1 −1
Original line number Diff line number Diff line
@@ -204,7 +204,7 @@ void qemu_set_dfilter_ranges(const char *filter_spec, Error **errp) 
        default:

            g_assert_not_reached();

        }

        if (lob > upb || (lob == 0 && upb == UINT64_MAX)) {

        if (lob > upb) {

            error_setg(errp, "Invalid range");

            goto out;

        }