Commit 58b59014 authored by Cole Robinson's avatar Cole Robinson Committed by Peter Maydell
Browse files

pci: Fix clearing IRQs on reset 



irq_state is cleared before calling pci_device_deassert_intx, but the
latter misbehaves if the former isn't accurate. In this case, any raised
IRQs are not cleared, which hits an assertion in pcibus_reset:

qemu-system-x86_64: hw/pci/pci.c:250: pcibus_reset: Assertion
`bus->irq_count[i] == 0' failed.

pci_device_deassert_intx should clear irq_state anyways, so add
an assert.

This fixes migration with usb2 + usb-tablet.

Signed-off-by: default avatarCole Robinson <crobinso@redhat.com>
Message-id: 7da1ad94ce027183b4049c2de370cb191b0073c1.1396290569.git.crobinso@redhat.com
Reviewed-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
Reviewed-by: default avatarMichael S. Tsirkin <mst@redhat.com>
Signed-off-by: default avatarPeter Maydell <peter.maydell@linaro.org>
parent 7d4d7975

hw/pci/pci.c

+2 −2
Original line number Diff line number Diff line
@@ -189,9 +189,9 @@ static void pci_do_device_reset(PCIDevice *dev) 
{

    int r;



    dev->irq_state = 0;

    pci_update_irq_status(dev);

    pci_device_deassert_intx(dev);

    assert(dev->irq_state == 0);



    /* Clear all writable bits */

    pci_word_test_and_clear_mask(dev->config + PCI_COMMAND,

                                 pci_get_word(dev->wmask + PCI_COMMAND) |