Commit 58602676 authored by Philippe Mathieu-Daudé's avatar Philippe Mathieu-Daudé Committed by Dr. David Alan Gilbert
Browse files

migration/colo: Add missing error-propagation code 



Running the coccinelle script produced:

  $ spatch \
    --macro-file scripts/cocci-macro-file.h --include-headers \
    --sp-file scripts/coccinelle/find-missing-error_propagate.cocci \
    --keep-comments --smpl-spacing --dir .
  HANDLING: ./migration/colo.c
  [[manual check required: error_propagate() might be missing in migrate_set_block_enabled() ./migration/colo.c:439:4]]

Add the missing error_propagate() after review.

Reviewed-by: default avatarJuan Quintela <quintela@redhat.com>
Signed-off-by: default avatarPhilippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20200413205250.687-1-f4bug@amsat.org>
Signed-off-by: default avatarDr. David Alan Gilbert <dgilbert@redhat.com>
parent 979da8b3

migration/colo.c

+3 −0
Original line number Diff line number Diff line
@@ -443,6 +443,9 @@ static int colo_do_checkpoint_transaction(MigrationState *s, 


    /* Disable block migration */

    migrate_set_block_enabled(false, &local_err);

    if (local_err) {

        goto out;

    }

    qemu_mutex_lock_iothread();



#ifdef CONFIG_REPLICATION