Commit 57d1f6d7 authored by Peter Maydell's avatar Peter Maydell
Browse files

sparc: Make sure we mmap at SHMLBA alignment 



SPARC Linux has an oddity that it insists that mmap()
of MAP_FIXED memory must be at an alignment defined by
SHMLBA, which is more aligned than the page size
(typically, SHMLBA alignment is to 16K, and pages are 8K).
This is a relic of ancient hardware that had cache
aliasing constraints, but even on modern hardware the
kernel still insists on the alignment.

To ensure that we get mmap() alignment sufficient to
make the kernel happy, change QEMU_VMALLOC_ALIGN,
qemu_fd_getpagesize() and qemu_mempath_getpagesize()
to use the maximum of getpagesize() and SHMLBA.

In particular, this allows 'make check' to pass on Sparc:
we were previously failing the ivshmem tests.

Signed-off-by: default avatarPeter Maydell <peter.maydell@linaro.org>
Reviewed-by: default avatarRichard Henderson <richard.henderson@linaro.org>
Message-id: 1512752248-17857-1-git-send-email-peter.maydell@linaro.org
parent a7cf5391

include/qemu/osdep.h

+3 −0
Original line number Diff line number Diff line
@@ -365,6 +365,9 @@ void qemu_anon_ram_free(void *ptr, size_t size); 
#elif defined(__linux__) && defined(__s390x__)

   /* Use 1 MiB (segment size) alignment so gmap can be used by KVM. */

#  define QEMU_VMALLOC_ALIGN (256 * 4096)

#elif defined(__linux__) && defined(__sparc__)

#include <sys/shm.h>

#  define QEMU_VMALLOC_ALIGN MAX(getpagesize(), SHMLBA)

#else

#  define QEMU_VMALLOC_ALIGN getpagesize()

#endif

util/mmap-alloc.c

+8 −0
Original line number Diff line number Diff line
@@ -35,6 +35,10 @@ size_t qemu_fd_getpagesize(int fd) 
            return fs.f_bsize;

        }

    }

#ifdef __sparc__

    /* SPARC Linux needs greater alignment than the pagesize */

    return QEMU_VMALLOC_ALIGN;

#endif

#endif



    return getpagesize();
@@ -60,6 +64,10 @@ size_t qemu_mempath_getpagesize(const char *mem_path) 
        /* It's hugepage, return the huge page size */

        return fs.f_bsize;

    }

#ifdef __sparc__

    /* SPARC Linux needs greater alignment than the pagesize */

    return QEMU_VMALLOC_ALIGN;

#endif

#endif



    return getpagesize();