Commit 577a1339 authored by Max Reitz's avatar Max Reitz Committed by Kevin Wolf
Browse files

file-posix: Fix shared locks on reopen commit 



s->locked_shared_perm is the set of bits locked in the file, which is
the inverse of the permissions actually shared.  So we need to pass them
as they are to raw_apply_lock_bytes() instead of inverting them again.

Reported-by: default avatarAlberto Garcia <berto@igalia.com>
Signed-off-by: default avatarMax Reitz <mreitz@redhat.com>
Reviewed-by: default avatarAlberto Garcia <berto@igalia.com>
Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
parent 9ad08c44

block/file-posix.c

+1 −1
Original line number Diff line number Diff line
@@ -959,7 +959,7 @@ static void raw_reopen_commit(BDRVReopenState *state) 


    /* Copy locks to the new fd before closing the old one. */

    raw_apply_lock_bytes(NULL, rs->fd, s->locked_perm,

                         ~s->locked_shared_perm, false, &local_err);

                         s->locked_shared_perm, false, &local_err);

    if (local_err) {

        /* shouldn't fail in a sane host, but report it just in case. */

        error_report_err(local_err);