Commit 56f68439 authored by Cédric Le Goater's avatar Cédric Le Goater Committed by David Gibson
Browse files

ppc/pnv: fix pnv_core_realize() error handling 



commit d35aefa9 ("ppc/pnv: introduce a new intc_create() operation
to the chip model") changed the object link in the pnv_core_realize()
routine but a return was forgotten in case of error, which can lead to
more problems afterwards (segv)

Signed-off-by: default avatarCédric Le Goater <clg@kaod.org>
Reviewed-by: default avatarGreg Kurz <groug@kaod.org>
Reviewed-by: default avatarPhilippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: default avatarDavid Gibson <david@gibson.dropbear.id.au>
parent abe82ebb

hw/ppc/pnv_core.c

+1 −0
Original line number Diff line number Diff line
@@ -150,6 +150,7 @@ static void pnv_core_realize(DeviceState *dev, Error **errp) 
    if (!chip) {

        error_propagate(errp, local_err);

        error_prepend(errp, "required link 'chip' not found: ");

        return;

    }



    pc->threads = g_new(PowerPCCPU *, cc->nr_threads);