Commit 5643cc94 authored by Dave Airlie's avatar Dave Airlie Committed by Gerd Hoffmann
Browse files

virtio-gpu-3d: add support for second capability set (v4) 



Due to a kernel bug we can never increase the size of capability
set 1, so introduce a new capability set in parallel, old userspace
will continue to use the old set, new userspace will start using
the new one when it detects a fixed kernel.

v2: don't use a define from virglrenderer, just probe it.
v3: fix compilation when virglrenderer disabled
v4: fix style warning, just use ?: op instead.

Signed-off-by: default avatarDave Airlie <airlied@redhat.com>
Message-id: 20180223023814.24459-1-airlied@gmail.com
Signed-off-by: default avatarGerd Hoffmann <kraxel@redhat.com>
parent 0a773d55

hw/display/virtio-gpu-3d.c

+15 −0
Original line number Diff line number Diff line
@@ -362,6 +362,11 @@ static void virgl_cmd_get_capset_info(VirtIOGPU *g, 
        virgl_renderer_get_cap_set(resp.capset_id,

                                   &resp.capset_max_version,

                                   &resp.capset_max_size);

    } else if (info.capset_index == 1) {

        resp.capset_id = VIRTIO_GPU_CAPSET_VIRGL2;

        virgl_renderer_get_cap_set(resp.capset_id,

                                   &resp.capset_max_version,

                                   &resp.capset_max_size);

    } else {

        resp.capset_max_version = 0;

        resp.capset_max_size = 0;
@@ -635,4 +640,14 @@ int virtio_gpu_virgl_init(VirtIOGPU *g) 
    return 0;

}



int virtio_gpu_virgl_get_num_capsets(VirtIOGPU *g)

{

    uint32_t capset2_max_ver, capset2_max_size;

    virgl_renderer_get_cap_set(VIRTIO_GPU_CAPSET_VIRGL2,

                              &capset2_max_ver,

                              &capset2_max_size);



    return capset2_max_ver ? 2 : 1;

}



#endif /* CONFIG_VIRGL */

hw/display/virtio-gpu.c

+6 −1
Original line number Diff line number Diff line
@@ -1215,7 +1215,12 @@ static void virtio_gpu_device_realize(DeviceState *qdev, Error **errp) 
        /* use larger control queue in 3d mode */

        g->ctrl_vq   = virtio_add_queue(vdev, 256, virtio_gpu_handle_ctrl_cb);

        g->cursor_vq = virtio_add_queue(vdev, 16, virtio_gpu_handle_cursor_cb);

        g->virtio_config.num_capsets = 1;



#if defined(CONFIG_VIRGL)

        g->virtio_config.num_capsets = virtio_gpu_virgl_get_num_capsets(g);

#else

        g->virtio_config.num_capsets = 0;

#endif

    } else {

        g->ctrl_vq   = virtio_add_queue(vdev, 64, virtio_gpu_handle_ctrl_cb);

        g->cursor_vq = virtio_add_queue(vdev, 16, virtio_gpu_handle_cursor_cb);

include/hw/virtio/virtio-gpu.h

+1 −1
Original line number Diff line number Diff line
@@ -171,5 +171,5 @@ void virtio_gpu_virgl_fence_poll(VirtIOGPU *g); 
void virtio_gpu_virgl_reset(VirtIOGPU *g);

void virtio_gpu_gl_block(void *opaque, bool block);

int virtio_gpu_virgl_init(VirtIOGPU *g);



int virtio_gpu_virgl_get_num_capsets(VirtIOGPU *g);

#endif

include/standard-headers/linux/virtio_gpu.h

+1 −0
Original line number Diff line number Diff line
@@ -260,6 +260,7 @@ struct virtio_gpu_cmd_submit { 
};



#define VIRTIO_GPU_CAPSET_VIRGL 1

#define VIRTIO_GPU_CAPSET_VIRGL2 2



/* VIRTIO_GPU_CMD_GET_CAPSET_INFO */

struct virtio_gpu_get_capset_info {