Commit 54d50be6 authored by Luiz Capitulino's avatar Luiz Capitulino
Browse files

qapi: Check for negative enum values 



We don't currently check for negative enum values in qmp_output_type_enum(),
this will very likely generate a segfault when triggered.

However, it _seems_ that no code in tree can trigger this today.

Acked-by: default avatarMichael Roth <mdroth@linux.vnet.ibm.com>
Signed-off-by: default avatarLuiz Capitulino <lcapitulino@redhat.com>
parent 3f5bd4e1

qapi/qmp-output-visitor.c

+1 −1
Original line number Diff line number Diff line
@@ -190,7 +190,7 @@ static void qmp_output_type_enum(Visitor *v, int *obj, const char *strings[], 


    assert(strings);

    while (strings[i++] != NULL);

    if (value >= i - 1) {

    if (value < 0 || value >= i - 1) {

        error_set(errp, QERR_INVALID_PARAMETER, name ? name : "null");

        return;

    }