Commit 543f8f13 authored by John Snow's avatar John Snow Committed by Michael Tokarev
Browse files

ide-test: check return of fwrite 



To quiet patchew, add an assert for fwrite's return value.

Signed-off-by: default avatarJohn Snow <jsnow@redhat.com>
Reviewed-by: default avatarJeff Cody <jcody@redhat.com>
Reviewed-by: default avatarLaurent Vivier <lvivier@redhat.com>
Signed-off-by: default avatarMichael Tokarev <mjt@tls.msk.ru>
parent f603164a

tests/ide-test.c

+6 −2
Original line number Diff line number Diff line
@@ -796,11 +796,13 @@ static void cdrom_pio_impl(int nblocks) 
    int i, j;

    uint8_t data;

    uint16_t limit;

    size_t ret;



    /* Prepopulate the CDROM with an interesting pattern */

    generate_pattern(pattern, patt_len, ATAPI_BLOCK_SIZE);

    fh = fopen(tmp_path, "w+");

    fwrite(pattern, ATAPI_BLOCK_SIZE, patt_blocks, fh);

    ret = fwrite(pattern, ATAPI_BLOCK_SIZE, patt_blocks, fh);

    g_assert_cmpint(ret, ==, patt_blocks);

    fclose(fh);



    ide_test_start("-drive if=none,file=%s,media=cdrom,format=raw,id=sr0,index=0 "
@@ -880,6 +882,7 @@ static void test_cdrom_pio_large(void) 
static void test_cdrom_dma(void)

{

    static const size_t len = ATAPI_BLOCK_SIZE;

    size_t ret;

    char *pattern = g_malloc(ATAPI_BLOCK_SIZE * 16);

    char *rx = g_malloc0(len);

    uintptr_t guest_buf;
@@ -896,7 +899,8 @@ static void test_cdrom_dma(void) 


    generate_pattern(pattern, ATAPI_BLOCK_SIZE * 16, ATAPI_BLOCK_SIZE);

    fh = fopen(tmp_path, "w+");

    fwrite(pattern, ATAPI_BLOCK_SIZE, 16, fh);

    ret = fwrite(pattern, ATAPI_BLOCK_SIZE, 16, fh);

    g_assert_cmpint(ret, ==, 16);

    fclose(fh);



    send_dma_request(CMD_PACKET, 0, 1, prdt, 1, send_scsi_cdb_read10);