Commit 543f7bef authored by Markus Armbruster's avatar Markus Armbruster Committed by Kevin Wolf
Browse files

qemu-io: Don't print NULL when open without non-option arg fails 



Reproducer: "open -o a=b".  Broken in commit fd0fee34.

Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
parent 29f2601a

qemu-io.c

+4 −2
Original line number Diff line number Diff line
@@ -62,7 +62,8 @@ static int openfile(char *name, int flags, int growable, QDict *opts) 
        if (bdrv_open(&qemuio_bs, name, NULL, opts, flags | BDRV_O_PROTOCOL,

                      NULL, &local_err))

        {

            fprintf(stderr, "%s: can't open device %s: %s\n", progname, name,

            fprintf(stderr, "%s: can't open%s%s: %s\n", progname,

                    name ? " device " : "", name ?: "",

                    error_get_pretty(local_err));

            error_free(local_err);

            return 1;
@@ -73,7 +74,8 @@ static int openfile(char *name, int flags, int growable, QDict *opts) 
        if (bdrv_open(&qemuio_bs, name, NULL, opts, flags, NULL, &local_err)

            < 0)

        {

            fprintf(stderr, "%s: can't open device %s: %s\n", progname, name,

            fprintf(stderr, "%s: can't open%s%s: %s\n", progname,

                    name ? " device " : "", name ?: "",

                    error_get_pretty(local_err));

            error_free(local_err);

            bdrv_unref(qemuio_bs);