Commit 53d6e531 authored by Laurent Vivier's avatar Laurent Vivier Committed by Markus Armbruster
Browse files

arm: remove remaining cannot_destroy_with_object_finalize_yet 



With commit ce5b1bbf ("exec: move cpu_exec_init() calls to
realize functions"), we can now remove all the
remaining cannot_destroy_with_object_finalize_yet as
unsafe references have been moved to cpu_exec_realizefn().
(tested with QOM command provided by commit 4c315c27).

Suggested-by: default avatarMarkus Armbruster <armbru@redhat.com>
Signed-off-by: default avatarLaurent Vivier <lvivier@redhat.com>
Reviewed-by: default avatarMarkus Armbruster <armbru@redhat.com>
Message-Id: <20170414083717.13641-2-lvivier@redhat.com>
Acked-by: default avatarAlistair Francis <alistair.francis@xilinx.com>
Acked-by: default avatarPeter Maydell <peter.maydell@linaro.org>
Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
parent 359c41ab

hw/arm/allwinner-a10.c

+0 −6
Original line number Diff line number Diff line
@@ -118,12 +118,6 @@ static void aw_a10_class_init(ObjectClass *oc, void *data) 
    DeviceClass *dc = DEVICE_CLASS(oc);



    dc->realize = aw_a10_realize;



    /*

     * Reason: creates an ARM CPU, thus use after free(), see

     * arm_cpu_class_init()

     */

    dc->cannot_destroy_with_object_finalize_yet = true;

}



static const TypeInfo aw_a10_type_info = {

hw/arm/bcm2836.c

+0 −6
Original line number Diff line number Diff line
@@ -160,12 +160,6 @@ static void bcm2836_class_init(ObjectClass *oc, void *data) 


    dc->props = bcm2836_props;

    dc->realize = bcm2836_realize;



    /*

     * Reason: creates an ARM CPU, thus use after free(), see

     * arm_cpu_class_init()

     */

    dc->cannot_destroy_with_object_finalize_yet = true;

}



static const TypeInfo bcm2836_type_info = {

hw/arm/digic.c

+0 −6
Original line number Diff line number Diff line
@@ -101,12 +101,6 @@ static void digic_class_init(ObjectClass *oc, void *data) 
    DeviceClass *dc = DEVICE_CLASS(oc);



    dc->realize = digic_realize;



    /*

     * Reason: creates an ARM CPU, thus use after free(), see

     * arm_cpu_class_init()

     */

    dc->cannot_destroy_with_object_finalize_yet = true;

}



static const TypeInfo digic_type_info = {

hw/arm/fsl-imx25.c

+0 −5
Original line number Diff line number Diff line
@@ -290,11 +290,6 @@ static void fsl_imx25_class_init(ObjectClass *oc, void *data) 


    dc->realize = fsl_imx25_realize;



    /*

     * Reason: creates an ARM CPU, thus use after free(), see

     * arm_cpu_class_init()

     */

    dc->cannot_destroy_with_object_finalize_yet = true;

    dc->desc = "i.MX25 SOC";

}

hw/arm/fsl-imx31.c

+0 −5
Original line number Diff line number Diff line
@@ -262,11 +262,6 @@ static void fsl_imx31_class_init(ObjectClass *oc, void *data) 


    dc->realize = fsl_imx31_realize;



    /*

     * Reason: creates an ARM CPU, thus use after free(), see

     * arm_cpu_class_init()

     */

    dc->cannot_destroy_with_object_finalize_yet = true;

    dc->desc = "i.MX31 SOC";

}