Commit 5351e69a authored by Wei Yang's avatar Wei Yang Committed by Dr. David Alan Gilbert
Browse files

migration/savevm: remove duplicate check of migration_is_blocked 



Current call flow of save_snapshot is:

  save_snapshot
    migration_is_blocked
      qemu_savevm_state
        migration_is_blocked

Since qemu_savevm_state is only called in save_snapshot, this means
migration_is_blocked has been already checked.

Signed-off-by: default avatarWei Yang <richardw.yang@linux.intel.com>
Message-Id: <20190424004700.12766-2-richardw.yang@linux.intel.com>
Reviewed-by: default avatarDr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: default avatarDr. David Alan Gilbert <dgilbert@redhat.com>
parent 4633456c

migration/savevm.c

+0 −4
Original line number Diff line number Diff line
@@ -1418,10 +1418,6 @@ static int qemu_savevm_state(QEMUFile *f, Error **errp) 
        return -EINVAL;

    }



    if (migration_is_blocked(errp)) {

        return -EINVAL;

    }



    if (migrate_use_block()) {

        error_setg(errp, "Block migration and snapshots are incompatible");

        return -EINVAL;