Commit 5330f32b authored by Vladimir Sementsov-Ogievskiy's avatar Vladimir Sementsov-Ogievskiy Committed by Max Reitz
Browse files

block/qcow2-bitmap: fix use of uninitialized pointer 



Without initialization to zero dirty_bitmap field may be not zero
for a bitmap which should not be stored and
qcow2_store_persistent_dirty_bitmaps will erroneously call
store_bitmap for it which leads to SIGSEGV on bdrv_dirty_bitmap_name.

Signed-off-by: default avatarVladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-id: 20170922144353.4220-1-vsementsov@virtuozzo.com
Cc: qemu-stable@nongnu.org
Reviewed-by: default avatarEric Blake <eblake@redhat.com>
Reviewed-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: default avatarMax Reitz <mreitz@redhat.com>
parent fefac70d

block/qcow2-bitmap.c

+1 −1
Original line number Diff line number Diff line
@@ -602,7 +602,7 @@ static Qcow2BitmapList *bitmap_list_load(BlockDriverState *bs, uint64_t offset, 
            goto fail;

        }



        bm = g_new(Qcow2Bitmap, 1);

        bm = g_new0(Qcow2Bitmap, 1);

        bm->table.offset = e->bitmap_table_offset;

        bm->table.size = e->bitmap_table_size;

        bm->flags = e->flags;