Commit 5320c2ca authored by Vladislav Yasevich's avatar Vladislav Yasevich Committed by Jason Wang
Browse files

net: Remove duplicate data from query-rx-filter on multiqueue net devices 



When responding to a query-rx-filter command on a multiqueue
netdev, qemu reports the data for each queue.  The data, however,
is not per-queue, but per device and the same data is reported
multiple times.  This causes confusion and may also cause extra
unnecessary processing when looking at the data.

Commit 638fb141 (net: Make qmp_query_rx_filter() with name argument
more obvious) partially addresses this issue, by limiting the output
when the name is specified.  However, when the name is not specified,
the issue still persists.

Signed-off-by: default avatarVladislav Yasevich <vyasevic@redhat.com>
Signed-off-by: default avatarJason Wang <jasowang@redhat.com>
parent eedeeeff

net/net.c

+6 −0
Original line number Diff line number Diff line
@@ -1227,6 +1227,12 @@ RxFilterInfoList *qmp_query_rx_filter(bool has_name, const char *name, 
            continue;

        }



        /* only query information on queue 0 since the info is per nic,

         * not per queue

         */

        if (nc->queue_index != 0)

            continue;



        if (nc->info->query_rx_filter) {

            info = nc->info->query_rx_filter(nc);

            entry = g_malloc0(sizeof(*entry));