Commit 52ae646d authored by Yeongkyoon Lee's avatar Yeongkyoon Lee Committed by Aurelien Jarno
Browse files

tcg: Fix occasional TCG broken problem when ldst optimization enabled 



is_tcg_gen_code() checks the upper limit of TCG generated code range wrong, so
that TCG could get broken occasionally only when CONFIG_QEMU_LDST_OPTIMIZATION
enabled. The reason is code_gen_buffer_max_size does not cover the upper range
up to (TCG_MAX_OP_SIZE * OPC_BUF_SIZE), thus code_gen_buffer_max_size should be
modified to code_gen_buffer_size.

CC: qemu-stable@nongnu.org
Signed-off-by: default avatarYeongkyoon Lee <yeongkyoon.lee@samsung.com>
Reviewed-by: default avatarPeter Maydell <peter.maydell@linaro.org>
Signed-off-by: default avatarAurelien Jarno <aurelien@aurel32.net>
parent 3f08ffb4

translate-all.c

+2 −2
Original line number Diff line number Diff line
@@ -1308,11 +1308,11 @@ static void tb_link_page(TranslationBlock *tb, tb_page_addr_t phys_pc, 
/* check whether the given addr is in TCG generated code buffer or not */

bool is_tcg_gen_code(uintptr_t tc_ptr)

{

    /* This can be called during code generation, code_gen_buffer_max_size

    /* This can be called during code generation, code_gen_buffer_size

       is used instead of code_gen_ptr for upper boundary checking */

    return (tc_ptr >= (uintptr_t)tcg_ctx.code_gen_buffer &&

            tc_ptr < (uintptr_t)(tcg_ctx.code_gen_buffer +

                    tcg_ctx.code_gen_buffer_max_size));

                    tcg_ctx.code_gen_buffer_size));

}

#endif