Commit 511aefb0 authored by Alon Levy's avatar Alon Levy Committed by Gerd Hoffmann
Browse files

hw/qxl: qxl_send_events: nop if stopped 

Added a trace point for easy logging.

RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=870972



Signed-off-by: default avatarAlon Levy <alevy@redhat.com>
Signed-off-by: default avatarGerd Hoffmann <kraxel@redhat.com>
parent 48f4ba67

hw/qxl.c

+7 −1
Original line number Diff line number Diff line
@@ -1701,7 +1701,13 @@ static void qxl_send_events(PCIQXLDevice *d, uint32_t events) 
    uint32_t le_events = cpu_to_le32(events);



    trace_qxl_send_events(d->id, events);

    assert(qemu_spice_display_is_running(&d->ssd));

    if (!qemu_spice_display_is_running(&d->ssd)) {

        /* spice-server tracks guest running state and should not do this */

        fprintf(stderr, "%s: spice-server bug: guest stopped, ignoring\n",

                __func__);

        trace_qxl_send_events_vm_stopped(d->id, events);

        return;

    }

    old_pending = __sync_fetch_and_or(&d->ram->int_pending, le_events);

    if ((old_pending & le_events) == le_events) {

        return;

trace-events

+1 −0
Original line number Diff line number Diff line
@@ -1001,6 +1001,7 @@ qxl_spice_update_area(int qid, uint32_t surface_id, uint32_t left, uint32_t righ 
qxl_spice_update_area_rest(int qid, uint32_t num_dirty_rects, uint32_t clear_dirty_region) "%d #d=%d clear=%d"

qxl_surfaces_dirty(int qid, int surface, int offset, int size) "%d surface=%d offset=%d size=%d"

qxl_send_events(int qid, uint32_t events) "%d %d"

qxl_send_events_vm_stopped(int qid, uint32_t events) "%d %d"

qxl_set_guest_bug(int qid) "%d"

qxl_interrupt_client_monitors_config(int qid, int num_heads, void *heads) "%d %d %p"

qxl_client_monitors_config_unsupported_by_guest(int qid, uint32_t int_mask, void *client_monitors_config) "%d %X %p"