Commit 50c75136 authored by Jeff Cody's avatar Jeff Cody Committed by Kevin Wolf
Browse files

block: mirror - remove code cruft that has no function 



Originally, this built up the error message with the backing filename,
so that errp was set as follows:
    error_set(errp, QERR_OPEN_FILE_FAILED, backing_filename);

However, we now propagate the local_error from the
bdrv_open_backing_file() call instead, making these 2 lines useless
code.

Signed-off-by: default avatarJeff Cody <jcody@redhat.com>
Reviewed-by: default avatarBenoit Canet <benoit@irqsave.net>
Reviewed-by: default avatarEric Blake <eblake@redhat.com>
Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
parent 90ce8a06

block/mirror.c

+0 −3
Original line number Diff line number Diff line
@@ -520,9 +520,6 @@ static void mirror_complete(BlockJob *job, Error **errp) 


    ret = bdrv_open_backing_file(s->target, NULL, &local_err);

    if (ret < 0) {

        char backing_filename[PATH_MAX];

        bdrv_get_full_backing_filename(s->target, backing_filename,

                                       sizeof(backing_filename));

        error_propagate(errp, local_err);

        return;

    }